Skip to content

Commit

Permalink
Clean up our usage of Bool in FFI (#229)
Browse files Browse the repository at this point in the history
* Python: Use ctypes.c_bool

* R shims: Be explicit about bool conversions

* Julia: use Bool instead of Cint in FFI
  • Loading branch information
WardBrian authored Apr 29, 2024
1 parent 2828e06 commit 19605fc
Show file tree
Hide file tree
Showing 5 changed files with 165 additions and 254 deletions.
11 changes: 1 addition & 10 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ on:
workflow_dispatch: {}

env:
CACHE_VERSION: 0
CACHE_VERSION: 1

# only run one copy per PR
concurrency:
Expand Down Expand Up @@ -270,12 +270,6 @@ jobs:
path: ./test_models/
key: ${{ hashFiles('**/*.stan', 'src/*', 'stan/src/stan/version.hpp', 'Makefile') }}-${{ matrix.os }}-v${{ env.CACHE_VERSION }}

- name: Install LLVM and Clang
uses: KyleMayes/install-llvm-action@v2
with:
version: "15.0"
directory: ${{ runner.temp }}/llvm

- name: Set up TBB
if: matrix.os == 'windows-latest'
run: |
Expand All @@ -284,9 +278,6 @@ jobs:
- name: Run rust tests
working-directory: ./rust
timeout-minutes: 60
env:
LIBCLANG_PATH: ${{ runner.temp }}/llvm/lib
LLVM_CONFIG_PATH: ${{ runner.temp }}/llvm/bin/llvm-config
run: |
cargo clippy
cargo fmt --check
Expand Down
Loading

0 comments on commit 19605fc

Please sign in to comment.