Add functionality to build models inside R #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WardBrian
added
enhancement
WardBrian
force-pushed
the
R/build-in-R
branch
from
1e9a688
to
1a400f9
Compare
WardBrian
force-pushed
the
R/build-in-R
branch
4 times, most recently
from
fc50988
to
1ac29e6
Compare
WardBrian
force-pushed
the
R/build-in-R
branch
from
1ac29e6
to
b9fefc4
Compare
|
I think this is ready now, but I'm still seeking some volunteer review from some of the Stan R programmers who will know more than me: @rok-cesnovar @jgabry @bgoodri If any of you have some spare cycles, it isn't all that much code. I'd be happy to hop on a call and talk through it as well. Appreciate it if you're able! |
|
If you can walk me through this, would be happy to review it. We can schedule on Slack. |
rok-cesnovar
approved these changes
Nov 28, 2023
roualdes
approved these changes
Nov 28, 2023
| return(output) | ||
| } | ||
|
|
||
| windows_path_setup <- function() { |
There was a problem hiding this comment.
I missed it. Where is this function used?
There was a problem hiding this comment.
It's called in the constructor before we load the shared object (same as Python, looks like Julia calls it at startup which is not ideal and I will take a look at with #187)
roualdes
approved these changes
Nov 29, 2023
This was referenced Mar 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses part of #100 and is more or less a straight port of the Python functionality.
I'm not at all a confident R programmer, so I'm going to ask if @jgabry or @rok-cesnovar could kindly spare some time to look this over.