Add a download flag to get_bridgestan_path #236
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roualdes
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
This looks good. Thanks for addressing this request. Happy to move forward as is.
Here's some nitpicks, but they're more like things I noticed while looking over this PR.
- Is there anything I'm missing about having lines like
path = CURRENT_BRIDGESTANinside the try-catch versus outside? - I see now that R/Python have
verify_bridgestan_path, while Julia hasvalidate_bridgestan_path, but it seems like they do the same thing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #220 (@avehtari)
This adds a flag
downloadto all the interfaces'get_bridgestan_pathfunctions. The default is true, which is the previous behavior. Setting tofalseallows you to inspect the current value without triggering a download if it is not found.Internally we always use the default value, but some users may want to check if their custom installation is working without triggering a download if it isn't.