Input size checks #241
Merged
Input size checks #241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roualdes
approved these changes
Aug 29, 2024
There was a problem hiding this comment.
Sorry for the super slow response on this. My bad.
This looks good to me.
It's nice in Python that we're getting some good use out of the array_ptr class. Keeps the implementation cleaner than in Julia or R.
Does the Rust implementation already do size checks?
|
Rust already did, yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Would close #239
I only timed this in Python, where I was not really able to consistently time a difference even in a very simple log density.
Note: Some existing code will fail after this is merged, even if that code is technically buggy. Worth noting in the release notes.