Add release target for workbench-session-init image #863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skyeturriff
requested review from
ianpittwood,
bschwedler and
costrouc
as code owners
bschwedler
approved these changes
Nov 6, 2024
|
I'm wondering if it would be better to hold off and put this in along with the updates we normally do for the Workbench release. That way we wouldn't need the interim |
…sion` to fetch version
…uild-fix-tests Use env var for WORKBENCH_SESSION_INIT_VERSION or default to `get-version` to fetch version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #862 to add the release build for the Workbench session init container image.
We're only building the session components for 2024.11.0, so I added a new
WORKBENCH_SESSION_INIT_VERSIONvariable that gets the daily version. Once we release 2024.11.0 and updateRSW_VERSIONin this repo, we can remove it and update the target steps to use the default release version.I think this will also require a new repo
rstudio/workbench-session-initto be added to our Docker hub.Part of https://github.com/rstudio/rstudio-pro/issues/6920