Skip to content

Commit

Permalink
chore: small edits to comments and NEWS item
Browse files Browse the repository at this point in the history
  • Loading branch information
gadenbuie authored Sep 30, 2024
1 parent 8c3cf16 commit 0424ac5
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion NEWS.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

* Fixed a bug with `sliderInput()` when used as a range slider that made it impossible to change the slider value when both handles were at the maximum value. (#4131)

* `dateInput` and `dateRangeInput` will not send spurious values to the server while typing until the user presses enter or clicks out of the field (except for `null` or `NA` when the field is completely empty). (#3664)
* `dateInput` and `dateRangeInput` no longer send immediate updates to the server when the user is typing a date input. Instead, it waits until the user presses Enter or clicks out of the field to send the update, avoiding spurious and incorrect date values. Note that an update is still sent immediately when the field is cleared. (#3664)

# shiny 1.9.1

Expand Down
2 changes: 1 addition & 1 deletion srcts/src/bindings/input/date.ts
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ class DateInputBindingBase extends InputBinding {
// event: Event
function () {
// Send immediately when clicked
// Or after typing, when enter pressed or focus lost
// Or if typing, when enter pressed or focus lost
callback(false);
}
);
Expand Down
2 changes: 1 addition & 1 deletion srcts/src/bindings/input/daterange.ts
Original file line number Diff line number Diff line change
Expand Up @@ -169,7 +169,7 @@ class DateRangeInputBinding extends DateInputBindingBase {
// event: Event
function () {
// Send immediately when clicked
// Or after typing, when enter pressed or focus lost
// Or if typing, when enter pressed or focus lost
callback(false);
}
);
Expand Down

0 comments on commit 0424ac5

Please sign in to comment.