fix(input_slider): Make sure last used handle is always above others (#…

…4131)
rstudio · Sep 27, 2024 · c489fef · c489fef
1 parent 9d12b0f
commit c489fef
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 3 deletions.
diff --git a/NEWS.md b/NEWS.md
@@ -4,14 +4,18 @@
 
 * Small improvements to the default pulse busy indicator to better blend with any background. It's also now slightly smaller by default. (#4122)
 
+## Bug fixes
+
+* Fixed a bug in `conditionalPanel()` that would cause the panel to repeatedly show/hide itself when the provided condition was not boolean. (@kamilzyla, #4127)
+
+* Fixed a bug with `input_slider()` when used as a range slider that made it impossible to change the slider value when both handles were at the maximum value. (#4131)
+
 # shiny 1.9.1
 
 ## Bug fixes
 
 * Fixed a bug introduced in v1.9.0 where the boundaries of hover/click/brush regions on plots were being incorrectly scaled when browser zoom was used. (#4111)
 
-* Fixed a bug in `conditionalPanel()` that would cause the panel to repeatedly show/hide itself when the provided condition was not boolean. (@kamilzyla, #4127)
-
 # shiny 1.9.0
 
 ## New busy indication feature

diff --git a/inst/www/shared/ionrangeslider/css/ion.rangeSlider.css b/inst/www/shared/ionrangeslider/css/ion.rangeSlider.css
@@ -235,6 +235,10 @@
   z-index: 2;
 }
 
+.irs--shiny .irs-handle.type_last {
+  z-index: 3;
+}
+
 .irs--shiny .irs-handle.state_hover, .irs--shiny .irs-handle:hover {
   background: #fff;
 }

diff --git a/inst/www/shared/ionrangeslider/scss/shiny.scss b/inst/www/shared/ionrangeslider/scss/shiny.scss
@@ -143,6 +143,11 @@ $font-family: $font-family-base !default;
     border-radius: $handle_width;
     z-index: 2;
 
+    &.type_last {
+      // Ensure last-used handle is on top if it overlaps with another handle
+      z-index: 3;
+    }
+
     &.state_hover,
     &:hover {
       background: $handle_color_hover;

diff --git a/tools/ion.rangeSlider-patches/0001-Add-skin-customized-for-Shiny.patch b/tools/ion.rangeSlider-patches/0001-Add-skin-customized-for-Shiny.patch
@@ -3,7 +3,7 @@ new file mode 100644
 index 00000000..ba052f8b
 --- /dev/null
 +++ b/inst/www/shared/ionrangeslider/scss/shiny.scss
-@@ -0,0 +1,201 @@
+@@ -0,0 +1,206 @@
 +/* 'shiny' skin for Ion.RangeSlider, largely based on the 'big' skin, but with smaller dimensions, grayscale grid text, and without gradients
 +© Posit, PBC, 2023
 +© RStudio, Inc, 2014
@@ -149,6 +149,11 @@ index 00000000..ba052f8b
 +    border-radius: $handle_width;
 +    z-index: 2;
 +
++    &.type_last {
++      // Ensure last-used handle is on top if it overlaps with another handle
++      z-index: 3;
++    }
++
 +    &.state_hover,
 +    &:hover {
 +      background: $handle_color_hover;