Update to the development version of selectize.js #3897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpsievert
force-pushed
the
selectize-0.15.2-update-part-2
branch
from
1836349
to
599e479
Compare
cpsievert
force-pushed
the
selectize-0.15.2-update-part-2
branch
from
599e479
to
cd74415
Compare
gadenbuie
approved these changes
Sep 14, 2023
|
Yea, hopefully. FWIW, I do subscribe to GH releases of various projects we care about (selectize, bootstrap, etc) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3896
This PR moves us from the v0.15.2 tag to the current
HEADof https://github.com/selectize/selectize.js. For reference, here are those changes:selectize/selectize.js@v0.15.2...e3f2e0b
Turns out those changes include some pretty important fixes to focus handling that not only fixes #3896, but also removes the need for the changes added to our
selectInputbinding as a part of the original v0.15.2 update (#3875) to fix this selectize issue (selectize/selectize.js#2032), so this PR also gets rid of that change (https://github.com/rstudio/shiny/pull/3875/files#diff-38d2e2c823f44474b8eb28e08331b223077004554c47884d287f18224d4f8fdc)