-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create shiny sass variable default files specific to Bootstrap Version #3914
Conversation
Reverts back to commit f540679
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks. Would also be great to have a short explanation of what this PR changes in terms of default Bootstrap 5 styles. Please also update news.
@gadenbuie it'd be great to get this in fairly soon, since it seems like it could impact testing screenshots. To that end, I am a bit surprised that |
Is that file compiled against BS3? In which case it'd be a good thing we don't see changes. |
@cpsievert Sorry, I forgot this was waiting on changes from me. I've removed the comments and added a news item. |
Ah, good point, thanks! |
I reverted
inst/www/shared/shiny_scss/bootstrap.scss
back to its state before the BS 5.3 updates. Those updates tried to support BS 3, 4 and 5.3 in the samebootstrap.scss
file.Then I created variants for each major version of Bootstrap. This allows us to confidently use features of each version of Bootstrap without a lot of checking for variable existence or having to backport Sass variables for older versions of Bootstrap.
The original
bootstrap.scss
had a small amount of backporting to simultaneously support BS3 and BS4; I removed the backports in each version.