Fix selectize.js tab focusing #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…scaping out of selectize.js dropdown to move onto next input
|
Reviewed this in person with @gadenbuie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following errors https://rstudio.github.io/shinycoreci/results/2023/09/11/#313-bslib-card-tab-focus-macOS-4.3, which were introduced by rstudio/shiny#3875
With the upgrade of selectize.js, when a multiple select is focused (and hence it's dropdown is shown), pressing Tab will add items instead of moving onto the next input. I'm not sure if this should be considered a regression in behavior that requires fixing, but regardless, it doesn't seem harmful to
Escapeto close the dropdown before moving to the next input.Note that the same is now done of the
dateRangeInput()(Escape+Tabshould ensure the dropdown closes before moving to the next focusable item)