Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure wait_for_value()'s ignore type is integer #242

Merged
merged 1 commit into from
Nov 2, 2023
Merged

Make sure wait_for_value()'s ignore type is integer #242

merged 1 commit into from
Nov 2, 2023

Conversation

cpsievert
Copy link
Contributor

See rstudio/shinytest2#368 for more context on why this matters

gadenbuie
gadenbuie approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@gadenbuie gadenbuie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oof, good catch!

@cpsievert cpsievert merged commit 75b1c56 into main Nov 2, 2023
15 of 20 checks passed
@cpsievert cpsievert deleted the wait-for-value-ignore-type branch November 2, 2023 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gadenbuie gadenbuie gadenbuie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpsievert @gadenbuie