Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build NotRestoredReasons for page #4

Merged
merged 7 commits into from
Jun 1, 2023
Merged

Build NotRestoredReasons for page #4

merged 7 commits into from
Jun 1, 2023

Conversation

rubberyuzu
Copy link
Owner

This PR adds a function to build NotRestoredReasons object for page, and calls the function from unload.
It also adds resetting logic of NotRestoredReasons at redirect.

Draft PR is here: whatwg#9360

PTAL @rakina

Copy link

@rakina rakina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with comments addressed

source Show resolved Hide resolved

<li><p><span data-x="list iterate">For each</span> <var>navigable</var> of
<var>documentState</var>'s <span data-x="document-state-document">document</span>'s
<span>descendant navigables</span>:</p>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also just iterate through crossOriginDescendants right?

@rubberyuzu rubberyuzu merged commit 7978361 into main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants