Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Grape::Util::Registrable + Small refactors #2475

Merged
merged 2 commits into from
Jul 22, 2024
Merged

Remove Grape::Util::Registrable + Small refactors #2475

merged 2 commits into from
Jul 22, 2024

Conversation

ericproulx
Copy link
Contributor

@ericproulx ericproulx commented Jul 21, 2024 •
edited
Loading

This PR will remove the Grape::Util::Registrable from the code base. The following classes has been adjusted and refactored:

  • Grape::Formatter
  • Grape::Parser
  • Grape::ErrorFormatter

I've haven't found any spec regarding the case Symbol for the classes above so its been removed intentionally.

Finally, I've added some memoize in Grape::Middleware::Base for content_types, mime_types and content_type_for

@ericproulx
Refactor ErrorFormatter, Parser and Formatter
da6e706 
Remove Grape::Util::Registrable
Add Grape::MimeTypes + spec
Small refactors
@ericproulx ericproulx marked this pull request as ready for review July 21, 2024 19:13
@ericproulx ericproulx requested a review from dblock July 21, 2024 20:52
@dblock dblock merged commit fb67ea9 into ruby-grape:master Jul 22, 2024
52 checks passed
@ericproulx ericproulx mentioned this pull request Oct 25, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dblock dblock dblock approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ericproulx @dblock