Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ostruct to dependencies in preparation of Ruby 3.5.0 #446

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

matthewbjones
Copy link
Contributor

After upgrading a project to Ruby version 3.3.5, we see the following warnings:

/Users/mjones/.rvm/gems/ruby-3.3.5@redacted-project-name/gems/rdf-3.3.2/lib/rdf.rb:5: warning: /Users/mjones/.rvm/rubies/ruby-3.3.5/lib/ruby/3.3.0/ostruct.rb was loaded from the standard library, but will no longer be part of the default gems starting from Ruby 3.5.0.
You can add ostruct to your Gemfile or gemspec to silence this warning.
Also please contact the author of rdf-3.3.2 to request adding ostruct into its gemspec.

This PR adds the ostruct library to the gemspec as suggested, which removes the warning when using the rdf gem.

@CLAassistant
Copy link

CLAassistant commented Sep 10, 2024

CLA assistant check
All committers have signed the CLA.

@coveralls
Copy link

Coverage Status

coverage: 91.739%. remained the same
when pulling a3b50b7 on matthewbjones:develop
into 12aee59 on ruby-rdf:develop.

@gkellogg gkellogg merged commit cfdeb1f into ruby-rdf:develop Sep 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants