-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omit #class
for simple values
#1004
base: master
Are you sure you want to change the base?
Conversation
11c2a89
to
5ad4edc
Compare
5ad4edc
to
697cce3
Compare
|
These values are assumed to be 0 if they're missing.
697cce3
to
507ecb6
Compare
❌ Tests Failed✖️11 tests failed ✔️658 tests passed(1 flake) 7/23 test sessions failed❌ Test session #3437636 failed details on CI ❌ Test session #3437631 failed details on CI ❌ Test session #3437630 failed details on CI ❌ Test session #3437627 failed details on CI ❌ Test session #3437626 failed details on CI ❌ Test session #3437621 failed details on CI ❌ Test session #3437619 failed details on CI |
Fixes ruby/vscode-rdbg#37
This PR depends on the changes in #1001. Only this last commit of this PR is unique to this change.
Description
The class of many values is self-evident and just clutters the UI:
(
false
andnil
don't have it, because of this bug described here)This PR omits the usual
#class
member for instances of these classes:NilClass
FalseClass
TrueClass
Symbol
String
Integer
Float
Class
Module
Array
Hash
The result is a much tidier UI you see in the "After" screenshot above.
This change still keeps the
#class
for other types, including subclasses of these simple types. For example,HashWithIndifferentAccess
is a subclass ofHash
. For clarity, we preserve its#class
, but omit it for regular hashes.