Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Ruby 3.4's new error message format #1080

Merged
merged 1 commit into from
Feb 20, 2024

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Feb 19, 2024

@hsbt hsbt force-pushed the no-backtick-in-error-messages branch from 68b848a to 7bb2530 Compare February 19, 2024 08:47
Copy link

launchable-app bot commented Feb 19, 2024

Launchable Report

❌ Test session #2631638 failedos:ubuntu-latest ruby:head test:protocol
🔔 no issues ✖️2 tests failed ✔️62 tests passed

❌ Test session #2631643 failedos:ubuntu-latest ruby:3.2 test:protocol
🔔 no issues ✖️1 test failed ✔️63 tests passed

❌ Test session #2631644 failedos:ubuntu-latest ruby:3.1 test:protocol
🔔 no issues ✖️1 test failed ✔️63 tests passed

❌ Test session #2631647 failedos:ubuntu-latest ruby:debug test:protocol
🔔 no issues ✖️2 tests failed ✔️62 tests passed

❌ Test session #2631660 failedos:ubuntu-latest ruby:head test:console
🔔 no issues ✖️2 tests failed ✔️295 tests passed

❌ Test session #2631703 failedos:macos-latest ruby:head test:console
🔔 no issues ✖️2 tests failed ✔️295 tests passed

❌ Test session #2631740 failedos:ubuntu-latest ruby:debug test:console
🔔 no issues ✖️2 tests failed ✔️295 tests passed

Passed test sessions

✅ Test session #2631630 passed os:ubuntu-latest ruby:3.0 test:test-framework
✅ Test session #2631631 passed os:ubuntu-latest ruby:head test:test-framework
✅ Test session #2631632 passed os:ubuntu-latest ruby:3.2 test:test-framework
✅ Test session #2631633 passed os:ubuntu-latest ruby:3.1 test:test-framework
✅ Test session #2631634 passed os:ubuntu-latest ruby:3.3 test:test-framework
✅ Test session #2631635 passed os:ubuntu-latest ruby:debug test:test-framework
✅ Test session #2631639 passed os:ubuntu-latest ruby:3.0 test:protocol
✅ Test session #2631640 passed os:ubuntu-latest ruby:3.3 test:protocol
✅ Test session #2631641 passed os:ubuntu-latest ruby:2.7 test:protocol
✅ Test session #2631650 passed os:ubuntu-latest ruby:2.7 test:console
✅ Test session #2631651 passed os:ubuntu-latest ruby:3.0 test:console
✅ Test session #2631652 passed os:ubuntu-latest ruby:3.1 test:console
✅ Test session #2631657 passed os:ubuntu-latest ruby:3.2 test:console
✅ Test session #2631658 passed os:ubuntu-latest ruby:3.3 test:console
✅ Test session #2631659 passed os:macos-latest ruby:3.2 test:console
✅ Test session #2631663 passed os:macos-latest ruby:3.3 test:console

Build: 7bb2530960645ab8fa98300b584382de8ff583cb

@ko1 ko1 merged commit cfa0da2 into master Feb 20, 2024
17 of 24 checks passed
@ko1 ko1 deleted the no-backtick-in-error-messages branch February 20, 2024 07:49
@ko1
Copy link
Collaborator

ko1 commented Feb 20, 2024

I'll submit another PR to catch up Ruby 3.4.

xjunior referenced this pull request in powerhome/audiences Apr 8, 2024
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence |
|---|---|---|---|---|---|
| [debug](https://togithub.com/ruby/debug) | `1.9.1` -> `1.9.2` |
[![age](https://developer.mend.io/api/mc/badges/age/rubygems/debug/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![adoption](https://developer.mend.io/api/mc/badges/adoption/rubygems/debug/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![passing](https://developer.mend.io/api/mc/badges/compatibility/rubygems/debug/1.9.1/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|
[![confidence](https://developer.mend.io/api/mc/badges/confidence/rubygems/debug/1.9.1/1.9.2?slim=true)](https://docs.renovatebot.com/merge-confidence/)
|

---

### Release Notes

<details>
<summary>ruby/debug (debug)</summary>

### [`v1.9.2`](https://togithub.com/ruby/debug/releases/tag/v1.9.2)

[Compare
Source](https://togithub.com/ruby/debug/compare/v1.9.1...v1.9.2)

#### What's Changed

-   config
- Make irb_console toggleable with config update by
[@&#8203;st0012](https://togithub.com/st0012) in
[https://github.com/ruby/debug/pull/1057](https://togithub.com/ruby/debug/pull/1057)
-   internal
- Stop assuming Array#each is written in C by
[@&#8203;k0kubun](https://togithub.com/k0kubun) in
[https://github.com/ruby/debug/pull/1061](https://togithub.com/ruby/debug/pull/1061)
- Add `base64` gem to the dependencies by
[@&#8203;y-yagi](https://togithub.com/y-yagi) in
[https://github.com/ruby/debug/pull/1066](https://togithub.com/ruby/debug/pull/1066)
- Support Ruby 3.4's new error message format by
[@&#8203;hsbt](https://togithub.com/hsbt) in
[https://github.com/ruby/debug/pull/1080](https://togithub.com/ruby/debug/pull/1080)
- catch up ruby 3.4.0 error related changes by
[@&#8203;ko1](https://togithub.com/ko1) in
[https://github.com/ruby/debug/pull/1083](https://togithub.com/ruby/debug/pull/1083)
- Fix syntax warnings by
[@&#8203;casperisfine](https://togithub.com/casperisfine) in
[https://github.com/ruby/debug/pull/1072](https://togithub.com/ruby/debug/pull/1072)
- Drop base64 dependency by
[@&#8203;Earlopain](https://togithub.com/Earlopain) in
[https://github.com/ruby/debug/pull/1071](https://togithub.com/ruby/debug/pull/1071)
- Fix ENOENT error when readline is not loaded by
[@&#8203;lazyatom](https://togithub.com/lazyatom) in
[https://github.com/ruby/debug/pull/1073](https://togithub.com/ruby/debug/pull/1073)
- Remove and Restore irb configuration like irbrc while irb console
tests by [@&#8203;hsbt](https://togithub.com/hsbt) in
[https://github.com/ruby/debug/pull/1067](https://togithub.com/ruby/debug/pull/1067)
- Use rb_iseqw_to_iseq to get iseq pointer by
[@&#8203;peterzhu2118](https://togithub.com/peterzhu2118) in
[https://github.com/ruby/debug/pull/1093](https://togithub.com/ruby/debug/pull/1093)
-   tests
- Add Ruby 3.3 to CI matrix by
[@&#8203;st0012](https://togithub.com/st0012) in
[https://github.com/ruby/debug/pull/1058](https://togithub.com/ruby/debug/pull/1058)
- Use ruby/actions workflow for ruby versions by
[@&#8203;m-nakamura145](https://togithub.com/m-nakamura145) in
[https://github.com/ruby/debug/pull/1065](https://togithub.com/ruby/debug/pull/1065)
- Separate setup and execution steps in CI by
[@&#8203;ono-max](https://togithub.com/ono-max) in
[https://github.com/ruby/debug/pull/1088](https://togithub.com/ruby/debug/pull/1088)
- Fix flakey test "test_reponse_returns_correct_threads_info" by
[@&#8203;ono-max](https://togithub.com/ono-max) in
[https://github.com/ruby/debug/pull/1089](https://togithub.com/ruby/debug/pull/1089)
- Add Launchable in CI by
[@&#8203;ono-max](https://togithub.com/ono-max) in
[https://github.com/ruby/debug/pull/1090](https://togithub.com/ruby/debug/pull/1090)
-   doc
- Correct the irb command's description by
[@&#8203;st0012](https://togithub.com/st0012) in
[https://github.com/ruby/debug/pull/1056](https://togithub.com/ruby/debug/pull/1056)
- Fix prelude doc example to use curly braces by
[@&#8203;adam12](https://togithub.com/adam12) in
[https://github.com/ruby/debug/pull/1052](https://togithub.com/ruby/debug/pull/1052)
- Mention IRB console in readme by
[@&#8203;st0012](https://togithub.com/st0012) in
[https://github.com/ruby/debug/pull/1092](https://togithub.com/ruby/debug/pull/1092)

#### New Contributors

- [@&#8203;Earlopain](https://togithub.com/Earlopain) made their first
contribution in
[https://github.com/ruby/debug/pull/1071](https://togithub.com/ruby/debug/pull/1071)
- [@&#8203;lazyatom](https://togithub.com/lazyatom) made their first
contribution in
[https://github.com/ruby/debug/pull/1073](https://togithub.com/ruby/debug/pull/1073)
- [@&#8203;m-nakamura145](https://togithub.com/m-nakamura145) made their
first contribution in
[https://github.com/ruby/debug/pull/1065](https://togithub.com/ruby/debug/pull/1065)

**Full Changelog**:
ruby/debug@v1.9.1...v1.9.2

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you
are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/powerhome/audiences).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjI2OS4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants