-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use default max_lines
when calling up
& down
#1094
base: master
Are you sure you want to change the base?
Conversation
I want to second this proposal as I also often need to chain |
c07fda0
to
caec1c5
Compare
Also probably useful to note that byebug-vs-debug.mov |
caec1c5
to
b1963e7
Compare
Launchable Report❌ Test session #2907805 failed details on CI ❌ Test session #2907807 failed details on CI Passed test sessions✅ Test session #2907791 passed details on CI Build: refs_pull_1094_merge_b1963e7b72554c9672900ba046c3088598955488 |
Seems the protocol tests are flaky: #1060 |
b1963e7
to
a1df646
Compare
Both `up` and `down` only show 1 source line when called, I think it would be more useful if they provided more context. This removes the `max_lines: 1` kwarg when they call `show_src`. `max_lines` in `show_src` will default to `CONFIG[:show_src_lines]`[^1]. [^1]:(https://github.com/ruby/debug/blob/0b77e8294b5b220b3b2a089bf09f94808654899a/lib/debug/thread_client.rb#L510)
a1df646
to
98a7521
Compare
Description
Both
up
anddown
only show 1 source line when called, I think it would be more useful if they provided more context. This removes themax_lines: 1
kwarg when they callshow_src
.max_lines
inshow_src
will default toCONFIG[:show_src_lines]
1.Big thanks to @st0012 for showing me and @bquorning where this behavior is defined.
Footnotes
(https://github.com/ruby/debug/blob/0b77e8294b5b220b3b2a089bf09f94808654899a/lib/debug/thread_client.rb#L510) ↩