Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning.rbs #23

Merged
merged 1 commit into from
May 26, 2023
Merged

Add warning.rbs #23

merged 1 commit into from
May 26, 2023

Conversation

akouryy
Copy link
Contributor

@akouryy akouryy commented May 18, 2023 •
edited
Loading

Added warning.rbs based on #19.

  • The auto-generated type of @out was IO, but @out can be a String in tests.
  • I could write the type of message to be string & _ToS, but I think it would be too complex.

@akouryy akouryy marked this pull request as draft May 18, 2023 13:20
@Little-Rubyist
Copy link
Contributor

Since Warning class has been removed from typeprof-generated.rbs, there seems no need to base #19 on it.
If we are not dependent on gem_rbs_collection, then we may check out from master.

@akouryy akouryy marked this pull request as ready for review May 24, 2023 15:50
@akouryy
Copy link
Contributor Author

akouryy commented May 24, 2023

Removed the dependency on #19.

@yui-knk
Copy link
Collaborator

yui-knk commented May 26, 2023

👍

@yui-knk yui-knk merged commit c895c70 into ruby:master May 26, 2023
@akouryy akouryy deleted the warning-rbs branch May 26, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@akouryy @Little-Rubyist @yui-knk