Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rbs_collection.yaml #32

Merged
merged 1 commit into from
May 25, 2023
Merged

Add rbs_collection.yaml #32

merged 1 commit into from
May 25, 2023

Conversation

akouryy
Copy link
Contributor

@akouryy akouryy commented May 24, 2023

Extracted changes related to rbs_collection from #19, following the comment below:

#19 (comment)

  • rbs_collection.yaml を入れるのは必要なので別のPRをつくっていただいてやるのがいいとおもいます

@yui-knk
Copy link
Collaborator

yui-knk commented May 25, 2023

Thanks for your PR. The change set seems good for me. Can I ask you to create PR from master branch directly? For example, you don't need to include 73a256a into this PR.

@akouryy
Copy link
Contributor Author

akouryy commented May 25, 2023

I reset the branch based on master and regenerated rbs_collection-related files.

@yui-knk yui-knk merged commit d4294c3 into ruby:master May 25, 2023
@yui-knk
Copy link
Collaborator

yui-knk commented May 25, 2023

Thank you!

@akouryy akouryy deleted the rbs_collection branch May 26, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants