Add "Additional Information" Field to Items for Bank Use Only #4643
Conversation
app/views/items/_form.html.erb
Outdated
| @@ -52,6 +52,12 @@ | |||
| <%= f.input :visible, label: "Item is Visible to Partners?", wrapper: :input_group do %> | |||
| <%= f.check_box :visible_to_partners, {class: "input-group-text", id: "visible_to_partners"}, "true", "false" %> | |||
| <% end %> | |||
|
|
|||
| <% if current_user.has_role?(Role::ORG_ADMIN, current_organization) || current_user.has_role?(Role::ORG_USER, current_organization) %> | |||
There was a problem hiding this comment.
I'm pretty sure this check is not necessary because only org users can get to this page. Same with the other partials. @cielf can you confirm?
There was a problem hiding this comment.
Only bank users can see this page, so we don't need a finer-grained control at this time.
There was a problem hiding this comment.
Noted. I will remove those check.
|
Also a bunch of failing tests :( |
|
@TheFaizanAnwar FYI: We had an urgent fix that required all the senior contributors this week , so we didn't get to look at this again. Hopefully this week will go better. |
|
Sure I will fix it asap. |
|
@cielf, I hope you're doing well. I have made the necessary changes based on your feedback on PR. Additionally, all the test cases are passing on my local environment, and I’ve attached a screenshot for your reference. I hope the tests will pass in the remote environment as well. |
|
Hey @dorner -- I think this one is in your court. |
|
@TheFaizanAnwar the tests are still failing. There are also conflicts now that have to be resolved. |
Resolves #4527
Description
This PR introduces an additional additional_info text field to the Items module, specifically for bank users. This field is added to the "new", "edit", "view", and "index" pages, and is only visible to users with bank-specific access. The purpose of this field is to allow banks to store/access particular information about items that partners do not need to see.
In the index view, the column header is shortened to "Add. Info" to prevent layout issues. Additionally, the text in this column is truncated to 25 characters to maintain the integrity of the table layout. Tests have been added to ensure this feature functions correctly.
Type of change
How Has This Been Tested?