Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The atomic_fetch ops are supposed to return the old value of the object. chibicc is currently returning the new values.
stdatomic.h:
I was originally thinking about how to fix this in a simple way. Three of them (add/sub/xor) are fixable with macros. Something like:
However,
atomic_fetch_and
andatomic_fetch_or
are not fixable via macro as they are not reversible.This PR adds a single new builtin (
__builtin_atomic_fetch_op
) which reuses the existing atomic operation code.