fix assembler error on large files #119
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the line_no must be unsigned. .loc N -NUM is invalid, leading to "Error: file number less than one." Ditto for file_no
we can put our headers there instead
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the line_no must be unsigned.
.loc N -NUM is invalid, leading to "Error: file number less than one." Ditto for file_no
it's a small compiler, but my generated .s file has still 518904 lines
oh, forgot: I added "/usr/local/include/x86_64-linux-gnu/chibicc" to the -I path, because I copied your headers there.