Binary add segfaults when at least 1 arg is non-numeric, and both are non-pointer types #42
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The following program segfaults in
new_add
function fromparse.c
Proposal
Check for the case when both args are non-pointer types; check
NULL
explicitly to improve readability.Note the following program still compiles with or without this patch:
It could be fixed easily, but like mentioned in #41, a separate "typecheck" phase would probably be a better solution IMHO.