Hashmap: Do not insert duplicate keys #98
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While looking into the table for a spot for the new key, search
until an empty one is found and do not overwrite tombstones.
Reported as #53.
Test
I was not able to find FNV colliding strings so instead I replaced the hash function and used a "dumb" one instead:
Then using the following test case I reproduced the issue:
The test passes when using 2c523f.
Signed-off-by: Kristiyan Stoimenov [email protected]