ch8/ch8-mac: Clear Unicast/Multicast bit #101
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match MAC address specification (eg, as summarised at https://en.wikipedia.org/wiki/MAC_address#Address_details) and Figure 8.4 of the text, clear the LSB of the 1st octet when generating the MAC address, rather than setting it. Also update check for "is_unicast()" to match.
Equivalent fix (from 2020-08-13) in the ch8-mget example: #7 (comment), which seems to have already been fixed when the first edition of the book was released (7d7955e):
code/ch8/ch8-mget/src/ethernet.rs
Lines 23 to 31 in 6ebd519
but apparently ch8/ch8-mac did not get fixed at the same time.