Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't pass -fPIC by default on wasm #1245

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Don't pass -fPIC by default on wasm #1245

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c1f07fc
Don't pass -fPIC by default on wasm
NobodyXu Oct 11, 2024
7b86b54
Fix cargo fmt
NobodyXu Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions src/lib.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1996,12 +1996,13 @@ impl Build {
cmd.push_cc_arg("-fdata-sections".into());
}
// Disable generation of PIC on bare-metal for now: rust-lld doesn't support this yet
if self.pic.unwrap_or(
if self.pic.unwrap_or_else(|| {
!target.contains("windows")
&& !target.contains("-none-")
&& !target.ends_with("-none")
&& !target.contains("uefi"),
) {
&& !target.contains("uefi")
&& !Build::is_wasi_target(target)
}) {
cmd.push_cc_arg("-fPIC".into());
// PLT only applies if code is compiled with PIC support,
// and only for ELF targets.
Expand Down