Subpart11 for async drop (major5) - shims codegen #129747
Draft
+2,990
−2,034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@azhogin I don't think you've made your code easier to review at all. |
Comment on lines
+363
to
+369
| /// Allows implementing `AsyncDrop`. | ||
| (incomplete, async_drop, "CURRENT_RUSTC_VERSION", Some(126482)), |
There was a problem hiding this comment.
Unstable library items do not get compiler feature gates.
Suggested change
| /// Allows implementing `AsyncDrop`. | |
| (incomplete, async_drop, "CURRENT_RUSTC_VERSION", Some(126482)), |
azhogin
force-pushed
the
azhogin/async-drop-subpart11-shims-codegen
branch
from
4d2435f
to
33841e6
Compare
…p from previous async drop glue implementation
azhogin
force-pushed
the
azhogin/async-drop-subpart11-shims-codegen
branch
from
33841e6
to
327f30e
Compare
azhogin
force-pushed
the
azhogin/async-drop-subpart11-shims-codegen
branch
from
327f30e
to
1e84499
Compare
|
☔ The latest upstream changes (presumably #130165) made this pull request unmergeable. Please resolve the merge conflicts. |
|
r? @nikomatsakis is going to look into this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is subpart 11 PR of #123948, just for review purposes.
Shims for:
async_drop_in_place<T>(dropee) -> async_drop_in_place<T>(dropee)::{{closure0}}async_drop_in_place<T>(dropee)::{{closure0}}for non-coroutine dropee types. When we need to generate drop glue (ladder) using drop elaboration and then StateTransform it into coroutine poll function.async_drop_in_place<T>(dropee)::{{closure0}}for coroutine dropee types. When we need to proxy call already generatedcoroutine_drop_async(produced in StateTransform pass of the coroutine T).Review only last commit, based on previous PR #129746.