Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove use of actions-rs #5571

Merged
merged 1 commit into from
Jan 29, 2023
Merged

Remove use of actions-rs #5571

merged 1 commit into from
Jan 29, 2023

Conversation

JohnTitor
Copy link
Member

actions-rs is currently inactive and has an issue like actions-rs/cargo#216, we could directly invoke Cargo instead.

Signed-off-by: Yuki Okushi [email protected]

@JohnTitor
Remove use of actions-rs
44be076 
Signed-off-by: Yuki Okushi <[email protected]>
ytmimi
ytmimi approved these changes Oct 27, 2022
View reviewed changes
Copy link
Contributor

@ytmimi ytmimi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! We invoke cargo directly almost everywhere else in CI so I think it's fine to remove actions-rs. Especially if it's not being maintained

@calebcartwright calebcartwright merged commit fb1a223 into rust-lang:master Jan 29, 2023
@JohnTitor JohnTitor deleted the drop-actions-rs branch January 29, 2023 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calebcartwright calebcartwright calebcartwright approved these changes

@ytmimi ytmimi ytmimi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JohnTitor @calebcartwright @ytmimi