Add disallowed labels to notify_zulip config #1382
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks good to me. The only question would be whether it should be "any" (i.e., disallowed it any of the labels match, versus all). But that seems to match the existing option. |
|
I'm not sure what exactly prompted issue #714 but I feel like this version should be enough for simple cases, and like you said, it matches the existing option. If need be, it can always be expanded |
|
Once conflicts are resolved here I'd be happy to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #714
I believe the proposed
include_labelsis already added asrequired_labels, correct me if I'm wrong though.