Hide no-merge comments once merge commits removed #1849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heavily inspired by the one in rust-log-analyzer https://github.com/rust-lang/rust-log-analyzer/blob/104ccd0e653c12342608bc41c520a37352b680fd/src/github.rs#L328-L348
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the a GraphQL call to minimize a comment, modifies the return of
post_commentto return the node-id (inside the more generalComment).And then use those pre-requires to hide all the no-merge comments once the merge commits are removed.
Fixes #1833
r? @ehuss