Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable isolated declarations #434

Closed
wants to merge 5 commits into from
Closed

Enable isolated declarations #434

wants to merge 5 commits into from

Conversation

wjhsf
Copy link
Contributor

@wjhsf wjhsf commented Jul 31, 2024

I recently learned about isolated declarations, which enforces some rules on type definitions that make it easier for downstream tooling to get type information without running a full type check. In order to do this, we have to slightly hide our custom inspect function.

I also switched us from importsNotUsedAsValues to verbatimModuleSyntax because the former is deprecated in favor of the latter.

@wjhsf
Copy link
Contributor Author

wjhsf commented Aug 6, 2024

Our tooling for API documentation generation doesn't recognize isolatedDeclarations. Since this isn't a priority, I'm going to close for now; we can revisit once the tooling has been updated.

@wjhsf wjhsf closed this Aug 6, 2024
@wjhsf wjhsf deleted the wjh/update-tsconfig branch August 6, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants