Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run rubocop autocorrect for consistent styles #477

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Run rubocop autocorrect for consistent styles #477

wants to merge 1 commit into from

Conversation

jcoyne
Copy link
Member

@jcoyne jcoyne commented Feb 22, 2019

No description provided.

@cjcolvar
Copy link
Member

I think if we're going to consistently apply and require rubocop, I'd like to switch over to bixby for consistency with other samvera gems and for the insulation that it provides from frequent rubocop changes.

@jcoyne
Copy link
Member Author

jcoyne commented Feb 22, 2019

@cjcolvar to be clear, this change does not add any dependency (such as rubocop or bixby), its only a cleanup of the style.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.46% when pulling 2fe7798 on rubocop into b76fc88 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 62.46% when pulling 2fe7798 on rubocop into b76fc88 on master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jcoyne @cjcolvar @coveralls