document some concerning issues about AdminSetOptionsPresenter's use

samvera · May 8, 2020 · 7883c6b · 7883c6b
1 parent 94df518
commit 7883c6b
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/app/presenters/hyrax/admin_set_options_presenter.rb b/app/presenters/hyrax/admin_set_options_presenter.rb
@@ -1,11 +1,16 @@
 module Hyrax
   # Presents the options for the AdminSet widget on the create/edit form
   class AdminSetOptionsPresenter
+    ##
+    # @param [Hyrax::AdminSetService] service
     def initialize(service)
       @service = service
     end
 
     # Return AdminSet selectbox options based on access type
+    #
+    # @todo this hits the Solr from the view. it would be better to avoid this.
+    #
     # @param [Symbol] access :deposit, :read, or :edit
     def select_options(access = :deposit)
       @service.search_results(access).map do |admin_set|

diff --git a/app/views/hyrax/base/_form_relationships.html.erb b/app/views/hyrax/base/_form_relationships.html.erb
@@ -1,5 +1,5 @@
 <% if Flipflop.assign_admin_set? %>
-  <%# TODO: consider `Hyrax::AdminSetOptionsPresenter.select_options_for(controller: controller)` instead %>
+  <%# TODO: avoid direct dependency on AdminSetService and AdminSetOptionsPresenter in the view!! make the controller provide the options! %>
   <%= f.input :admin_set_id, as: :select,
       include_blank: false,
       collection: Hyrax::AdminSetOptionsPresenter.new(Hyrax::AdminSetService.new(controller)).select_options,