♻️ Favor method_missing over a raft of delegates #6763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeremyf
force-pushed
the
favor-method-missing-over-all-that-delegation
branch
from
a1517e1
to
6951cd0
Compare
jeremyf
force-pushed
the
favor-method-missing-over-all-that-delegation
branch
from
6951cd0
to
1a2c4b8
Compare
It's like we're flooding a political convention with delegates. Instead of having all of those delegate methods, let's just implement method missing and pass things along to the `SolrDocument`. The benefit is that as we incorporate dynamic metadata, we don't need to keep on adding `delegate :this_property, to: :solr_document`.
jeremyf
force-pushed
the
favor-method-missing-over-all-that-delegation
branch
from
1a2c4b8
to
a3d4a8f
Compare
|
I like this. I was surprised to still need to customize the presenter (and other files) when we have the metadata schema yaml files in place. However, I'm going to wait until after 5.0.1 to merge this. |
bkiahstroud
reviewed
Apr 1, 2024
Co-authored-by: Kiah Stroud <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's like we're flooding a political convention with delegates. Instead of having all of those delegate methods, let's just implement method missing and pass things along to the
SolrDocument.The benefit is that as we incorporate dynamic metadata, we don't need to keep on adding
delegate :this_property, to: :solr_document.@samvera/hyrax-code-reviewers