Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding alt attribute on thumbnail in search results list view #6911

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

jlhardes
Copy link
Contributor

Fixes

Fixes #6749 - This adds alternative text on thumbnails in the search results list view but not on the gallery or masonry views. Those views currently have empty alt attributes and are passing accessibility test via SiteImprove but are not actually providing any alternative text.

Summary

Calling up work title and using that for alternative text attribute value

Type of change (for release notes)

  • notes-minor Addresses accessibility-concern of missing alternative text

@samvera/hyrax-code-reviewers

@jlhardes
Copy link
Contributor Author

jlhardes commented Sep 25, 2024

Also addresses #6891 (same report using WAVE instead of SiteImprove)

Copy link

github-actions bot commented Sep 25, 2024

Test Results

    17 files  ±0      17 suites  ±0   2h 16m 53s ⏱️ +18s
 6 706 tests ±0   6 409 ✅ +1  297 💤 ±0  0 ❌  - 1 
13 180 runs  ±0  12 785 ✅ +1  395 💤 ±0  0 ❌  - 1 

Results for commit 36b4120. ± Comparison against base commit e4886f1.

This pull request removes 273 and adds 273 tests. Note that renamed tests count towards both.
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f708253d708>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f9074f16a60>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f7082531188>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f9075496918>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: 44f92cfc-02b8-4e52-8c30-c00fd19bfdd7
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 81c62b64-8048-4b86-8eb4-198eb8bc1fe1
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: a725e3af-48a9-4fe7-a1dc-5a6c1444088f
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 0cfada86-f26e-4fd4-b65a-15c3b1926af0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: a8a7a7b7-b461-48cf-b4d8-f5854af674f9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 1ad8889c-a2ff-48b9-8d97-18ad577b7a12
…
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007f1a25a54240>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplate:0x00007fc701443fc0>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007f1a257ad348>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to create #<Hyrax::PermissionTemplateAccess:0x00007fc701d49b10>
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy AdminSet: d000e8d2-cd92-4211-852a-8f2adbe76234
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to destroy Hyrax::AdministrativeSet: 7dca803e-0350-4252-ae24-6e3d08fff48d
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit AdminSet: 0a8e6ea9-993b-4216-bd63-948b25bb51d0
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to edit Hyrax::AdministrativeSet: 8114fa21-7055-41df-9dda-c8bb7c342c66
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update AdminSet: 06b83772-fbf5-4e1d-8d28-636a1e6271b9
spec.abilities.ability_spec ‑ Hyrax::Ability AdminSets and PermissionTemplates a user without edit access is expected not to be able to update Hyrax::AdministrativeSet: 27b78c42-4132-49d8-8383-98343478918c
…

♻️ This comment has been updated with latest results.

@dlpierce dlpierce merged commit aeb5e3e into main Sep 26, 2024
22 checks passed
@dlpierce dlpierce deleted the issue-6749 branch September 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

thumbnails and thumbnail links missing alt text
2 participants