Add VirusTotal Results to API #92
Conversation
knightzac19
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## staging #92 +/- ##
===========================================
- Coverage 20.56% 19.58% -0.98%
===========================================
Files 247 256 +9
Lines 58404 61115 +2711
===========================================
- Hits 12011 11972 -39
- Misses 43863 46629 +2766
+ Partials 2530 2514 -16 ☔ View full report in Codecov by Sentry. |
|
|
||
| func (VirustotalResult) Annotations() []schema.Annotation { | ||
| return []schema.Annotation{ | ||
| entsql.Annotation{Table: "virustotal_results"}, |
There was a problem hiding this comment.
Isn't this the same name it would be using anyway? Why override it?
There was a problem hiding this comment.
The generator was making the table virus_total_results
| @@ -78,7 +78,7 @@ func ScanFiles(ctx context.Context, files []io.Reader, names []string) ([]ScanRe | |||
| _ = errs.Wait() | |||
| close(c) | |||
| }() | |||
| var results []ScanResult | |||
| results := make([]ScanResult, 0, 100) | |||
There was a problem hiding this comment.
Why 100? Why even give a size?
There was a problem hiding this comment.
Saw this error in the linter,
validation/virustotal.go:81:2: Consider pre-allocating `results` (prealloc)
var results []ScanResult
^
There was a problem hiding this comment.
I think that just initializing a 0-size should be enough, setting a cap will cause problems when someone tries to upload a mod with 101 scanable items
There was a problem hiding this comment.
The linter is probably detecting that the channel will pass at most len(fileCount) items, and wants you to use that as the initial size, make([]ScanResult, len(fileCount))
There was a problem hiding this comment.
Actually, this should probably be rewritten as a select with a loop, because:
- We are just ignoring if the
errsreturns an error - We are not guaranteed that
fileCountmany items will be sent toc
Here is the API for the virustotal resultset from the API. First time I've ever messed with GraphQL to this extent, so I'm sure there's a lot of missing pieces to this.