[1.x] Generate AbstractZincFile during -sourcepath workflow
#1309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Friendseeker
commented
Dec 15, 2023
internal/compiler-bridge/src/main/scala/xsbt/CallbackGlobal.scala
Outdated
Show resolved
Hide resolved
dwijnand
requested changes
Jan 3, 2024
internal/compiler-bridge/src/main/scala/xsbt/CallbackGlobal.scala
Outdated
Show resolved
Hide resolved
This was referenced Sep 27, 2024
Friendseeker
requested review from
eed3si9n and
dwijnand
and removed request for
dwijnand
Friendseeker
changed the title
ZincPlainFile during -sourcepath workflowZincPlainFile during -sourcepath workflow
Friendseeker
changed the title
ZincPlainFile during -sourcepath workflowAbstractZincFile during -sourcepath workflow
Friendseeker
force-pushed
the
plainfile-match-fail
branch
4 times, most recently
from
99fbd8f
to
6a1ef09
Compare
eed3si9n
approved these changes
Sep 30, 2024
In certain codepath, unit.source.file is a PlainFile, which causes a MatchError. This PR converts PlainFile to AbstractZincFile, avoiding the MatchError.
Friendseeker
force-pushed
the
plainfile-match-fail
branch
from
cf8095d
to
7696f6c
Compare
|
@eed3si9n While the PR is in My concern is that since this PR involves |
|
Yea. Now that AnalysisCallback is AnalysisCallback3, we should just land this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1304, #963
Issue
zinc/internal/compiler-bridge/src/main/scala/xsbt/API.scala
Line 62 in 5eb0de1
In certain codepath,
unit.source.fileis aPlainFile, which causes aMatchError.Fix
When
unit.sourceis built, convertunit.source.filetoAbstractZincFile.Validating the fix
The PR includes reproduction scripted test by lrytz. The test passes after the fix.