Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve landing page - topic cloud, SJS/SN/scala highlights #1163

Merged
merged 8 commits into from
Aug 8, 2023

Conversation

keynmol
Copy link
Contributor

@keynmol keynmol commented Feb 14, 2023

Commence the bikeshedding!

Main changes:

  • Denoise the tag cloud, by removing parentheses and moving library count into superscripts
  • Highlight current versions of Scala, SJS, SN, SBT/Mill - older versions are relegated into much smaller space, to not create the impression that all are equally prominent

Before:
image

After (note that local data doesn't have mill plugins, so it's not showing up)
image

Copy link
Contributor

@sjrd sjrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice. Two small suggestions.

@julienrf
Copy link
Contributor

julienrf commented Feb 14, 2023

Thank you @keynmol for working on this PR! I like the new tag cloud, and I like the fact that we emphasize stable versions of Scala, sbt, etc., but I feel like the logos take too much space and overall the content is misaligned.

@keynmol
Copy link
Contributor Author

keynmol commented Feb 14, 2023

but I feel like the logos take too much space and overall the content is misaligned

I agree about the misalignment, let me try to flex a bit more.

With regards to logos, I could make them smaller - in particular I think if the Scala logos will be same size (or actually smaller) than the scalajs/native ones, it will look cleaner.

Will do another pass, and if it's a no go - will remove them completely.

@bishabosha
Copy link
Member

bishabosha commented Feb 14, 2023

Wow so cool, thanks! My small comment (looking at the screenshot): I'd prefer if the "project count" and "other versions" for Scala.js and Scala Native were on their own lines and aligned

@keynmol
Copy link
Contributor Author

keynmol commented Feb 14, 2023

Logos were too fiddly to get right, they all have different sizes and different empty space around them.

  • Removed the logos and descriptions
  • greyed out versions that are truly deprecated
  • Centered everything
  • Projects and versions are separate paragraphs

image

- Removed the logos and descriptions
- Greyed out versions that are truly deprecated
- Centered everything
- Projects and versions are separate paragraphs
@julienrf
Copy link
Contributor

Thank you again for your work! The screenshot looks good to me!

Do you mind posting screenshots for various sizes of screens (especially tablet and mobile)?

@keynmol
Copy link
Contributor Author

keynmol commented Feb 14, 2023

@julienrf I took a few screenshots - seems fine at first sight.

On really narrow things we can add a media query and just flex the entire list into a single column, but imo there's not many screens around with a resolution that low to care :)

Screenshot 2023-02-14 at 16 24 08

Screenshot 2023-02-14 at 16 23 56

Screenshot 2023-02-14 at 16 23 46

@keynmol
Copy link
Contributor Author

keynmol commented Feb 18, 2023

@julienrf anything else you would want to change here?

I still think that even this (toned down) version is an improvement, but I'm happy to adjust if you have any more ideas :)

Copy link
Member

@adpi2 adpi2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @keynmol for this great proposal and for implementing it. It is very much welcome. Scaladex deserves a better front page and unfortunately we did not find much time to work on it.

I left a few comments about the code style. Here are a few more comments about the design itself:

  • I think we can remove the deprecated information, to improve the readability. Because currently it is hard to understand that the style of 2.12 is different because 2.12 is not deprecated.
    image
  • I would expect the "181 projects" to be clickable as part of the "Scala 2.13" box, because clicking on "Scala 2.13" brings to the list of projects.
  • I don't like the "Build tool plugins" title floating alone in the middle of the page. It would be more consistent if we also put titles above the Scala versions and the platform versions. But I would not mind putting no titles at all. Anywhere else on Scaladex, sbt and Mill are considered platforms, in the same way as Scala.js and Scala Native.

Those comments are open to discussion. Also if you don't want to implement the changes now, I would be okay to merge and improve later.

modules/server/src/main/assets/css/partials/_main.scss Outdated Show resolved Hide resolved
build.sbt Outdated Show resolved Hide resolved
@adpi2
Copy link
Member

adpi2 commented Feb 21, 2023

For testing, I deployed this PR to the dev environment: https://index-dev.scala-lang.org/

@adpi2 adpi2 self-assigned this Aug 2, 2023
@adpi2
Copy link
Member

adpi2 commented Aug 2, 2023

I am taking this PR over to push it to the finish line.

@adpi2 adpi2 merged commit e9e5d4c into scalacenter:main Aug 8, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants