Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remap ESModule imports at link time in mdoc #883
Remap ESModule imports at link time in mdoc #883
Changes from 29 commits
0438cb7
0e0e859
54b015f
dfde131
e823704
2cc6eda
1b1f096
7729ef0
fca69ab
f382b3e
c67a83a
2e8ae38
9006060
eaa4c16
5376abb
57d3710
eb88458
16e794b
b89da7f
e94ffcc
ba8056d
4198a0f
6adc334
533b8b5
b2206d7
0a1fc9b
ff78365
aca5269
23c082f
cf59660
9962de3
6ca3b32
9e4c5e9
6f30481
1291803
832424a
480b1ed
28b2e1b
50b86fe
39b12a5
95bd8f6
bedebef
64b7748
f3ed917
41b8231
4511c9d
4fa3cd9
c7e3519
64ee2f1
432cdda
b63b588
7ad139a
2505970
cc9a3c9
93e3440
58349ce
27806fb
596d7c0
96dabd0
c4ebc98
eb73393
a7f4f02
2872fb9
0d2ed3a
33e3f31
a1f5559
dc9b6ef
6df4338
3a4765c
cb1e50c
316f741
682b5b8
f3363c8
6c6f6da
cf3ef94
7e76eb9
7e97011
e7b140e
03ea40e
bc0b4a8
11f882d
6afbc6d
1089279
81bfd41
2675800
8957145
225e92b
fbd4a98
62038db
2a79c0e
007f494
12cdf90
84bf280
fefb8f6
b40cabb
0301afa
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you used "mdoc.properties" above, line 167, please create a constant and use in both places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could be I'm missing something, but as far as I can tell, this would require the constant to be moved outside of the
Settings
class - it would essentially become a global variable inmdoc.internal.cli
Is this what you intend? It would not be my choice.