Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(CopyButton): fix children type #4357

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

johnrazeur
Copy link
Contributor

Summary

Type

  • Bug

Summarise concisely:

The following changes where made:

Fix CopyButton children prop type.

@johnrazeur johnrazeur self-assigned this Oct 17, 2024
Copy link

changeset-bot bot commented Oct 17, 2024

🦋 Changeset detected

Latest commit: c3b4fae

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@ultraviolet/ui Patch
@ultraviolet/form Patch
@ultraviolet/plus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@ac23bbc). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #4357   +/-   ##
=======================================
  Coverage        ?   86.81%           
=======================================
  Files           ?      316           
  Lines           ?    11569           
  Branches        ?     3204           
=======================================
  Hits            ?    10044           
  Misses          ?     1525           
  Partials        ?        0           
Files with missing lines Coverage Δ
packages/ui/src/components/CopyButton/index.tsx 100.00% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac23bbc...c3b4fae. Read the comment docs.

@@ -16,7 +17,7 @@ type CopyButtonProps = {
bordered?: boolean
className?: string
'data-testid'?: string
children?: string
children?: ReactNode
Copy link
Collaborator

@matthprost matthprost Oct 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was done on purpose to be a string. Why do you need a react node ? We don't want the devs to be able to put anything else than a string to avoid having style suprises.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it because of translation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants