-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(CopyButton): fix children type #4357
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: c3b4fae The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4357 +/- ##
=======================================
Coverage ? 86.81%
=======================================
Files ? 316
Lines ? 11569
Branches ? 3204
=======================================
Hits ? 10044
Misses ? 1525
Partials ? 0
Continue to review full report in Codecov by Sentry.
|
@@ -16,7 +17,7 @@ type CopyButtonProps = { | |||
bordered?: boolean | |||
className?: string | |||
'data-testid'?: string | |||
children?: string | |||
children?: ReactNode |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done on purpose to be a string. Why do you need a react node ? We don't want the devs to be able to put anything else than a string to avoid having style suprises.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it because of translation?
Summary
Type
Summarise concisely:
The following changes where made:
Fix
CopyButton
children prop type.