AbstractConverter: make deprecated API consistent #404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imagejan
force-pushed
the
fix-deprecation
branch
from
f1dd9ba
to
06b9c28
Compare
The canConvert(Class, Class) signature is deprecated in the Converter interface, so let's deprecate the overridden method as well, as it's the case for canConvert(Class, Type) already.
imagejan
force-pushed
the
fix-deprecation
branch
from
06b9c28
to
6c3ed41
Compare
ctrueden
force-pushed
the
master
branch
3 times, most recently
from
53b6733
to
3dc99c9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
canConvert(Class, Class)signature is deprecated in theConverterinterface, so let's deprecate the overridden method as well, as it's the case forcanConvert(Class, Type)already.