Ignore empty Strings during String to FileArray conversion #479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stefanhahmann
commented
Jun 27, 2024
stefanhahmann
commented
- The current state of the code is that an empty String, is converted to a new File("") object initialized with an empty String
- A File object instantiated by this will be a File object with an absolute Path that is equivalent to the Path from which the application was started
- The result of this is a bit unpredictable
- This PR thus suggests that an empty String should not be converted to File object at all and not be added to the output
* The current state of the code is that an empty String, is converted to a new File("") object with an empty String
* A File object instantiated by this will be a File object with an absolute Path that is equivalent to the Path from which the application was started
* The result of this is relatively unpredictable
* Thus empty String should not be converted to File object and not be added to the output
19 tasks
…ded for String to File Array conversion
imagejan
approved these changes
Jul 4, 2024
|
@stefanhahmann Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.