Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PEP632: Remove depracted call of distutils.version.LooseVersion #141

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

braniii
Copy link
Contributor

@braniii braniii commented Apr 25, 2022

Hello,

I am sorry for the short PR yesterday, but I got interrupted. So my concern is that import scikit-learn-extra in a pytest environment leads to raising warnings. I need to admit, that I am not able to reproduce a minimal working example.

I would suggest to remove the depracted call of distutils.version.LooseVersion with packaging.version.Version. The reason is that starting from Python 3.12 the distutils package will be removed, see PEP634. In the packaging module there is no LooseVersion, but regarding the strict versioning of sklearn and numpy this should make no difference.

PS: I've just notice that it is checked against version below the INSTALL_REQUIRES. So it should be save deleting these checks completely.

INSTALL_REQUIRES = ["numpy>=1.13.3", "scipy>=0.19.1", "scikit-learn>=0.23.0"]

@braniii
Copy link
Contributor Author

braniii commented Oct 26, 2023

Python 3.12 support has been added to scikit-learn, see scikit-learn/scikit-learn#27027. So this would be the first step towards supporting py3.12 with the latest sklearn 1.3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants