-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(feat): read_lazy
for xarray
reading + read_elem_as_dask
-> read_elem_lazy
#1247
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1247 +/- ##
==========================================
- Coverage 86.99% 84.81% -2.18%
==========================================
Files 40 45 +5
Lines 6045 6416 +371
==========================================
+ Hits 5259 5442 +183
- Misses 786 974 +188
|
68fcd2b
to
6165f07
Compare
Discussion point: creating dummy indices to speed up first-load time. The real index will simply be stored in |
if any( | ||
isinstance(el, (sparse.spmatrix, SpArray)) | ||
or ( | ||
isinstance(el, DaskArray) | ||
and isinstance(el._meta, (sparse.spmatrix, SpArray)) | ||
) | ||
for el in els | ||
): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bug @ivirshup or @flying-sheep? Needs its own PR? This was spitting out NaNs before for dask-sparse
xarray
with experimental backed
readingread_lazy
for xarray
reading + read_elem_as_dask
-> read_lazy_elem
read_lazy
for xarray
reading + read_elem_as_dask
-> read_lazy_elem
read_lazy
for xarray
reading + read_elem_as_dask
-> read_elem_lazy
Done, tested, with |
This PR is a lighter weight version of #947 that involves using the original
AnnData
object as the class to holdobs
andvar
xr.Dataset
..obs
and.var
withbacked="r"
mode #981