tests/unit: add a unit test for json2code #2229
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
test-for-json2code
branch
2 times, most recently
from
1839ac1
to
d8ad883
Compare
|
pending on #2223 |
this change addresses a regression introduced by 3f534c7, which failed to differentiate the path param from the non-path param, and always prefixed the param with "/". Fixes 3f534c7 Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
test-for-json2code
branch
from
d8ad883
to
92524b1
Compare
before this change, we don't have a test for scripts/seastar-json2code.py. to verify the behavior of this script, let's add an integration test which exercise an http server which uses the source code generated with this script. Fixes scylladb#2225 Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
test-for-json2code
branch
from
92524b1
to
a136703
Compare
|
closing in favor of #2223 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, we don't have a test for
scripts/seastar-json2code.py. to verify the behavior of this script, let's add an integration test which exercise an http server which uses the source code generated with this script.
Fixes #2225
Signed-off-by: Kefu Chai [email protected]