build: add compiler and C++ standard compatibility checks #2463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tchaikov
force-pushed
the
build-check-compiler-standard
branch
2 times, most recently
from
18a4379
to
8675d56
Compare
we install `SeastarConfig.cmake` so that a Seastar project can consume the Seastar libraries using `find_package(Seastar)`. this CMake config file checks for the dependencies used by CMake, and defines the Seastar libraries to be consumed by the parent project. one of the dependence is detected using FindSourceLocation.cmake, which is also shipped along with Seastar, this find module is provided so that we can detect the C++ compiler support of `std::source_location` related features. But the result of the detection depends on the C++ standard used, which is default to the one configured by the used C++ compiler if not specified. if the parent project consumes precompiled Seastar libraries, and use a differnt C++ standard, the parent project could fail to build, because Seastar and parent project are using different compiling options. mismatches in C++ standards or compilers between Seastar and the parent project can lead to build failures or runtime issues. while not always problematic, these mismatches can cause unexpected behavior. in this change, we detect - the C++ standards used by the parent project and Seastar - the C++ compiler used by the parent project and Seastar warnings are non-fatal as compatibility is possible in some cases, but developers should be aware of potential issues and test thoroughly. Fixes scylladb#2181 Signed-off-by: Kefu Chai <[email protected]>
tchaikov
force-pushed
the
build-check-compiler-standard
branch
from
8675d56
to
4738bf8
Compare
|
Rather than check compatibility, can we inherit the compiler/standard from the parent project? I can't think of a reason why they'd be different. |
|
@avikivity Hi Avi, what this changes is the CMake config file. It is
shipped/installed by a pre-compiled Seastar library. We cannot predict what
compiler or C++ standard used by the parent project when compiling Seastar.
Regards
Kefu Chai
Avi Kivity ***@***.***>于2024年10月1日 周二19:47写道：
… Rather than check compatibility, can we inherit the compiler/standard from
the parent project? I can't think of a reason why they'd be different.
—
Reply to this email directly, view it on GitHub
<#2463 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAONP2CG4AQ37WS746SSNDZZKDVFAVCNFSM6AAAAABPFBMLS6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBVGU3DIMJUGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we install
SeastarConfig.cmakeso that a Seastar project can consume the Seastar libraries usingfind_package(Seastar). this CMake config file checks for the dependencies used by CMake, and defines the Seastar libraries to be consumed by the parent project. one of the dependence is detected using FindSourceLocation.cmake, which is also shipped along with Seastar, this find module is provided so that we can detect the C++ compiler support ofstd::source_locationrelated features. But the result of the detection depends on the C++ standard used, which is default to the one configured by the used C++ compiler if not specified. if the parent project consumes precompiled Seastar libraries, and use a differnt C++ standard, the parent project could fail to build, because Seastar and parent project are using different compiling options.mismatches in C++ standards or compilers between Seastar and the parent project can lead to build failures or runtime issues. while not always problematic, these mismatches can cause unexpected behavior.
in this change, we detect
warnings are non-fatal as compatibility is possible in some cases, but developers should be aware of potential issues and test thoroughly.
Fixes #2181
Signed-off-by: Kefu Chai [email protected]