Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FIX: Remove download on error #1290

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

FIX: Remove download on error #1290

wants to merge 1 commit into from

Conversation

marc0der
Copy link
Member

No description provided.

@@ -32,7 +32,7 @@ function __sdkman_secure_curl() {

function __sdkman_secure_curl_download() {
local curl_params
curl_params=('--progress-bar' '--location')
curl_params=('--progress-bar' '--location' '--remove-on-error')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! I would actually challenge my own suggestion 😄! While that would work for newer versions of curl, it may break on older versions, no?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, and it shows 😆

curl: option --remove-on-error: is unknown

@helpermethod
Copy link
Member

helpermethod commented Apr 17, 2024

I think a much more portable solution would to be to perform the cleanup in sdkman-install.sh

__sdkman_secure_curl_download "${download_url}" --output "${binary_input}" --dump-header "${tmp_headers_file}" || rm "${binary_input}"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants