Add deny list config for EVM RPC #1427
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codchen
approved these changes
Mar 12, 2024
jewei1997
reviewed
Mar 12, 2024
| timeouts := rpc.DefaultHTTPTimeouts | ||
| timeouts.WriteTimeout = time.Second | ||
| srv := createAndStartServer(t, &evmrpc.HTTPConfig{ | ||
| DenyList: []string{"test_sleep"}, |
There was a problem hiding this comment.
I don't think the test_sleep endpoint exists on this server. Might be good to try to denylist an endpoint that exists like test for this test.
There was a problem hiding this comment.
oh just saw this, I think we added that as a new module in the config itself, if you look at previous test cases, it seems to be a valid endpoint
udpatil
pushed a commit
that referenced
this pull request
Mar 26, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 18, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
This PR add a new configuration for EVM RPC to configure deny list. If a method appears in deny list, the server will return an error response to indicate the method is not found.
Config would be look like:
deny_list = ["eth_a", "eth_b"]
Testing performed to validate your change
Added unit test for deny list.