Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Reject blob txs #1498

Merged
merged 3 commits into from
Apr 2, 2024
Merged

[EVM] Reject blob txs #1498

merged 3 commits into from
Apr 2, 2024

Conversation

stevenlanders
Copy link
Contributor

Describe your changes and provide context

  • once we support blobs we can re-enable, but for safety this disables type 3 txs

Testing performed to validate your change

  • unit tests

@stevenlanders stevenlanders changed the base branch from main to seiv2 April 1, 2024 15:07
@codecov-commenter
Copy link

codecov-commenter commented Apr 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 61.01%. Comparing base (4c225f4) to head (33216aa).
Report is 1 commits behind head on seiv2.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##            seiv2    #1498      +/-   ##
==========================================
- Coverage   61.32%   61.01%   -0.32%     
==========================================
  Files         361      361              
  Lines       25332    25345      +13     
==========================================
- Hits        15535    15463      -72     
- Misses       8885     8973      +88     
+ Partials      912      909       -3     
Files Coverage Δ
x/evm/ante/basic.go 40.74% <100.00%> (-6.23%) ⬇️

... and 3 files with indirect coverage changes

@stevenlanders stevenlanders merged commit 548078b into seiv2 Apr 2, 2024
44 checks passed
@stevenlanders stevenlanders deleted the reject-blob-txs branch April 2, 2024 12:30
udpatil pushed a commit that referenced this pull request Apr 17, 2024
udpatil pushed a commit that referenced this pull request Apr 17, 2024
udpatil pushed a commit that referenced this pull request Apr 17, 2024
udpatil pushed a commit that referenced this pull request Apr 18, 2024
udpatil pushed a commit that referenced this pull request Apr 19, 2024
udpatil pushed a commit that referenced this pull request Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants