Add CW->ERC pointer registry #1499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -51,7 +52,7 @@ | |||
|
|
|||
| func MockEVMKeeper() (*evmkeeper.Keeper, sdk.Context) { | |||
| testApp := app.Setup(false, false) | |||
| ctx := testApp.GetContextForDeliverTx([]byte{}).WithBlockHeight(8) | |||
| ctx := testApp.GetContextForDeliverTx([]byte{}).WithBlockHeight(8).WithBlockTime(time.Now()) | |||
Check warning
Code scanning / CodeQL
Calling the system time Warning test
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## seiv2 #1499 +/- ##
==========================================
- Coverage 61.32% 60.95% -0.38%
==========================================
Files 361 363 +2
Lines 25332 25506 +174
==========================================
+ Hits 15535 15546 +11
- Misses 8885 9047 +162
- Partials 912 913 +1
|
codchen
force-pushed
the
cw-erc-pointer-registry
branch
4 times, most recently
from
85acc22
to
fd1dec3
Compare
codchen
force-pushed
the
cw-erc-pointer-registry
branch
from
fd1dec3
to
3d73b1d
Compare
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Add CW->ERC pointer registry * fix tests
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Add CW->ERC pointer registry * fix tests
udpatil
pushed a commit
that referenced
this pull request
Apr 17, 2024
* Add CW->ERC pointer registry * fix tests
udpatil
pushed a commit
that referenced
this pull request
Apr 18, 2024
* Add CW->ERC pointer registry * fix tests
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Add CW->ERC pointer registry * fix tests
udpatil
pushed a commit
that referenced
this pull request
Apr 19, 2024
* Add CW->ERC pointer registry * fix tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes and provide context
Add pointer registry and new transaction types for CosmWasm pointer over ERC20/721 contracts. The pointer code is only stored once (either during genesis or migration) and re
instantiatedwhenever aRegisterPointertransaction is processed.The versioning logic is the same as ERC->CW pointers. Note that there is no governance proposal needed for CW->ERC pointers because there is no metadata like decimals and symbols that need to be supplied (and agreed upon) at pointer creation.
Testing performed to validate your change
unit tests